-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix default file system error handler for disk_failure_policy die
Patch by Runtian Liu; reviewed by brandonwilliams and smiklosovic for CASSANDRA-18294
- Loading branch information
Showing
6 changed files
with
321 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121 changes: 121 additions & 0 deletions
121
test/unit/org/apache/cassandra/service/DefaultFSErrorHandlerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.cassandra.service; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Arrays; | ||
| import java.util.Collection; | ||
|
|
||
| import org.junit.After; | ||
| import org.junit.AfterClass; | ||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.Parameterized; | ||
|
|
||
| import org.apache.cassandra.SchemaLoader; | ||
| import org.apache.cassandra.config.Config; | ||
| import org.apache.cassandra.config.DatabaseDescriptor; | ||
| import org.apache.cassandra.exceptions.ConfigurationException; | ||
| import org.apache.cassandra.gms.Gossiper; | ||
| import org.apache.cassandra.io.FSErrorHandler; | ||
| import org.apache.cassandra.io.FSReadError; | ||
| import org.apache.cassandra.io.sstable.CorruptSSTableException; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| @RunWith(Parameterized.class) | ||
| public class DefaultFSErrorHandlerTest | ||
| { | ||
| private FSErrorHandler handler = new DefaultFSErrorHandler(); | ||
| Config.DiskFailurePolicy oldDiskPolicy; | ||
| Config.DiskFailurePolicy testDiskPolicy; | ||
| private boolean gossipRunningFSError; | ||
| private boolean gossipRunningCorruptedSStableException; | ||
|
|
||
| @BeforeClass | ||
| public static void defineSchema() throws ConfigurationException | ||
| { | ||
| SchemaLoader.prepareServer(); | ||
| CassandraDaemon daemon = new CassandraDaemon(); | ||
| daemon.completeSetup(); //startup must be completed, otherwise FS error will kill JVM regardless of failure policy | ||
| StorageService.instance.registerDaemon(daemon); | ||
| StorageService.instance.initServer(); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void shutdown() | ||
| { | ||
| StorageService.instance.stopClient(); | ||
| } | ||
|
|
||
| @Before | ||
| public void setup() | ||
| { | ||
| StorageService.instance.startGossiping(); | ||
| assertTrue(Gossiper.instance.isEnabled()); | ||
| oldDiskPolicy = DatabaseDescriptor.getDiskFailurePolicy(); | ||
| } | ||
|
|
||
| public DefaultFSErrorHandlerTest(Config.DiskFailurePolicy policy, | ||
| boolean gossipRunningFSError, | ||
| boolean gossipRunningCorruptedSStableException) | ||
| { | ||
| this.testDiskPolicy = policy; | ||
| this.gossipRunningFSError = gossipRunningFSError; | ||
| this.gossipRunningCorruptedSStableException = gossipRunningCorruptedSStableException; | ||
| } | ||
|
|
||
| @Parameterized.Parameters | ||
| public static Collection<Object[]> generateData() | ||
| { | ||
| return Arrays.asList(new Object[][]{ | ||
| { Config.DiskFailurePolicy.die, false, false}, | ||
| { Config.DiskFailurePolicy.ignore, true, true}, | ||
| { Config.DiskFailurePolicy.stop, false, true}, | ||
| { Config.DiskFailurePolicy.stop_paranoid, false, false}, | ||
| { Config.DiskFailurePolicy.best_effort, true, true} | ||
| } | ||
| ); | ||
| } | ||
|
|
||
| @After | ||
| public void teardown() | ||
| { | ||
| DatabaseDescriptor.setDiskFailurePolicy(oldDiskPolicy); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFSErrors() | ||
| { | ||
| DatabaseDescriptor.setDiskFailurePolicy(testDiskPolicy); | ||
| handler.handleFSError(new FSReadError(new IOException(), "blah")); | ||
| assertEquals(gossipRunningFSError, Gossiper.instance.isEnabled()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testCorruptSSTableException() | ||
| { | ||
| DatabaseDescriptor.setDiskFailurePolicy(testDiskPolicy); | ||
| handler.handleCorruptSSTable(new CorruptSSTableException(new IOException(), "blah")); | ||
| assertEquals(gossipRunningCorruptedSStableException, Gossiper.instance.isEnabled()); | ||
| } | ||
| } |
Oops, something went wrong.