CASSANDRA-16900 - ArrayCell#unsharedHeapSizeExcludingData includes data twice #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
commented
Aug 30, 2021
| @@ -43,7 +45,7 @@ public BufferCell(ColumnMetadata column, long timestamp, int ttl, int localDelet | |||
| { | |||
| super(column); | |||
| assert !column.isPrimaryKeyColumn(); | |||
| assert column.isComplex() == (path != null); | |||
| assert column.isComplex() == (path != null) : format("Column %s.%s(%s: %s) isComplex: %b with cellpath: %s", column.ksName, column.cfName, column.name, column.type.toString(), column.isComplex(), path); | |||
There was a problem hiding this comment.
this is a nit from me; asserts should have messages to help (not needed for the patch, but is useful)
dcapwell
commented
Aug 30, 2021
| @@ -78,7 +78,7 @@ public NativeCell(NativeAllocator allocator, | |||
| assert column.isComplex() == (path != null); | |||
| if (path != null) | |||
| { | |||
| assert path.size() == 1; | |||
| assert path.size() == 1 : String.format("Expected path size to be 1 but was not; %s", path); | |||
There was a problem hiding this comment.
this is a nit from me; asserts should have messages to help (not needed for the patch, but is useful)
maedhroz
reviewed
Aug 30, 2021
maedhroz
reviewed
Aug 30, 2021
maedhroz
approved these changes
Aug 30, 2021
dcapwell
force-pushed
the
CASSANDRA-16900
branch
from
e7b755d
to
76e2746
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.