Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent broken concurrent schema read/writes #1277

Closed
wants to merge 2 commits into from
Closed

Prevent broken concurrent schema read/writes #1277

wants to merge 2 commits into from

Conversation

bereng
Copy link
Contributor

@bereng bereng commented Oct 20, 2021

No description provided.

@bereng
Copy link
Contributor Author

bereng commented Oct 20, 2021 •
edited

@maedhroz the 3.11 version is slightly different. Both classes are in different packages, also SchemaKeyspace is already sync'ing on static on a few methods. It makes little sense to me to move everything into Schema imo. The easiest is to add static sync'ing where needed.

I have trouble making your test fail despite having tried several hook points for the BM. I could use a little help here. Edit: as usual next day you find the problem in 5m. I had to make the sleep 5s but it certainly fails now when sync is removed.

@bereng
Copy link
Contributor Author

bereng commented Oct 20, 2021 •
edited

I have to look into this one, it is deadlocking now https://app.circleci.com/pipelines/github/bereng/cassandra/476/workflows/970669eb-e533-42b8-a9ef-d96ff2fcf04d/jobs/4135/parallel-runs/0/steps/0-104

Edit: Had forgotten an extra sync

@bereng
Copy link
Contributor Author

bereng commented Oct 20, 2021

CI lgtm

@bereng
Copy link
Contributor Author

bereng commented Oct 21, 2021

CI lgtm

maedhroz
maedhroz requested changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@maedhroz maedhroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped a few minor comments, and then there are a couple changes to the test we should probably make sure we get in. Let me know if any of them don't make sense.

@bereng
Copy link
Contributor Author

bereng commented Oct 22, 2021

Nicer test indeed now addressing my concern on it. Pushed changes.

@bereng
Copy link
Contributor Author

bereng commented Oct 22, 2021

CI lgtm

@bereng
Copy link
Contributor Author

bereng commented Oct 25, 2021

CI lgtm

@bereng bereng deleted the CASSANDRA-16996-3.11 branch May 26, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maedhroz maedhroz maedhroz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@bereng @maedhroz @smiklosovic