Cassandra 17033 #1304
Closed
Cassandra 17033 #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maedhroz
reviewed
Nov 9, 2021
| }); | ||
| return promise; |
There was a problem hiding this comment.
So to summarize my understanding, waiting for binding, the previously returned Future was insufficient, because the body of the listener is not guaranteed to run before it presents itself as complete. So (taking care to protect the shared mutable state of binding and listen), we create a separate promise whose completion guarantees that the state we need to change has already been changed. If so, +1 :)
maedhroz
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.