CASSANDRA-17423 Add Native Transport Rate Limiter Options to Example cassandra.yaml and Expose Metric for Dispatch Rate #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and expose metric for dispatch rate patch by Caleb Rackliffe; reviewed by ? for CASSANDRA-17423
jmckenzie-dev
approved these changes
Mar 15, 2022
| # enabled, the server will stop consuming messages from the channel/socket, putting backpressure on | ||
| # the client while already dispatched messages are processed. | ||
| # native_transport_rate_limiting_enabled: false | ||
| # native_transport_max_requests_per_second: 1000000 |
There was a problem hiding this comment.
Why this default value? Thinking of an operator that might see this, say "Oh, I like this feature", and enable it thinking it's going to help them when 1M seems... high. :)
There was a problem hiding this comment.
Yeah, the idea was that I wanted to make sure that even if an operator accidentally enabled the feature, it would still have a very high limit, something that wouldn't disrupt operations, until set explicitly. Then, once a reasonable limit for a workload is established, the enable switch is there to activate and deactivate that limit. WDYT?
|
Committed in 4ea3e4c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.