Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSANDRA-17432 bumped version to 6.1.0 #1506

Closed
wants to merge 1 commit into from
Closed

CASSANDRA-17432 bumped version to 6.1.0 #1506

wants to merge 1 commit into from

Conversation

bschoening
Copy link
Contributor

No description provided.

@smiklosovic smiklosovic changed the title bumped version to 6.1.0 CASSANDRA-17432 bumped version to 6.1.0 Mar 16, 2022
@@ -39,7 +39,7 @@ be sitting in front of a prompt:

----
Connected to Test Cluster at localhost:9160.
[cqlsh 2.2.0 | Cassandra 1.2.0 | CQL spec 3.0.0 | Thrift protocol 19.35.0]
[cqlsh 6.0.0 | Cassandra 4.0.2 | CQL spec 3.4.5 | Native protocol v5]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the other part of this PR bumps this to 6.1.0, shouldn't this also bump cqlsh to 6.1.0?

This is trunk, so you want to match the rest of code on trunk, not what's in the most recent release...

Similarly, may wish to update the other versions to match whatever is currently on trunk.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffwidman I thought about that, but the examples don't need to track minor release versions. It just needs to be updated for major releases, if that.

However, it was kinda silly and potentially confusing that it still referenced Thrift and cqlsh 2.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad, I didn't realize this was merely code examples. Your thinking makes complete sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants