Remove the useless conditions. #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values of the three conditions have been narrowed by previous conditions. They have no effect on the current control flow. http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jul 13, 2021
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Aug 31, 2021
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f) (cherry picked from commit d478c9f)
jacek-lewandowski
pushed a commit
to jacek-lewandowski/cassandra
that referenced
this pull request
Mar 7, 2022
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f) (cherry picked from commit d478c9f) (cherry picked from commit 1a3f8b3)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Mar 21, 2022
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f) (cherry picked from commit d478c9f) (cherry picked from commit 1a3f8b3)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jun 13, 2022
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f) (cherry picked from commit d478c9f) (cherry picked from commit 1a3f8b3) (cherry picked from commit ed21da3)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 24, 2022
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f) (cherry picked from commit d478c9f) (cherry picked from commit 1a3f8b3) (cherry picked from commit ed21da3) (cherry picked from commit 17fab85)
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Sep 26, 2023
We can disable saving of the history either via command-line parameter --disable-history, or by setting disabled = True in the history section of the cqlshrc. Both options will read existing history, and just won't save new commands. Co-authored-by: Alex Ott alex.ott@datastax.com (cherry picked from commit ff1bc1f) (cherry picked from commit d478c9f) (cherry picked from commit 1a3f8b3) (cherry picked from commit ed21da3) (cherry picked from commit 17fab85) (cherry picked from commit 62d43e1) (+2 squashed commits) Squashed commits: [f11e9c7e2ea] STAR-431: Add option to prevent any file-I/O from cqlsh (apply from correct version of cqlsh.py this time) (apache#170) (cherry picked from commit 38a4915) (cherry picked from commit 0b65dd4) (cherry picked from commit 271f1f1) (cherry picked from commit 29b8d06) (cherry picked from commit 567c6c8) (cherry picked from commit 1060c56) [da773eb67ed] STAR-431: Add option to prevent any file-I/O from cqlsh Co-authored-by: Robert Stupp <snazy@snazy.de> (cherry picked from commit d7e5ff4) (cherry picked from commit bd6096e) (cherry picked from commit 0d7bdd7) (cherry picked from commit d3fe3d3) (cherry picked from commit dbbd7bb) (cherry picked from commit afdc4fc) (cherry picked from commit 1b586e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values of the three conditions have been narrowed by previous conditions.
They have no effect on the current control flow.
http://findbugs.sourceforge.net/bugDescriptions.html#UC_USELESS_CONDITION