[CASSANDRA-16418]: Unsafe to run nodetool cleanup during bootstrap or decommission #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/distributed/org/apache/cassandra/distributed/test/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
test/distributed/org/apache/cassandra/distributed/test/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
linzuro
force-pushed
the
CASSANDRA-16418
branch
2 times, most recently
from
d14d074
to
8705b1d
Compare
linzuro
force-pushed
the
CASSANDRA-16418
branch
from
8705b1d
to
fe29f53
Compare
Update CleanupFailureTest to perform deterministic cleanup bootstrap/decommission
smiklosovic
reviewed
Jan 13, 2023
test/distributed/org/apache/cassandra/distributed/test/ring/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
linzuro
requested review from
pauloricardomg and
smiklosovic
and removed request for
pauloricardomg and
smiklosovic
smiklosovic
reviewed
Jan 17, 2023
test/distributed/org/apache/cassandra/distributed/test/ring/CleanupFailureTest.java
Outdated
Show resolved
Hide resolved
smiklosovic
reviewed
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
To reproduce, run cleanup on a node receiving data while another node is being decommissioned. I created 20 sstables of data.
patch by Lindsey Zurovchak; reviewed by Paulo Motta for CASSANDRA-16418