-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASSANDRA-18131 Fix LongBTreeTest test timeout #2178
base: trunk
Are you sure you want to change the base?
Conversation
…reeTest hunging test
fa996fe
to
c6b9132
Compare
@@ -785,7 +784,7 @@ public void testBatchesSmallOverlappingRange() throws ExecutionException, Interr | |||
@Test | |||
public void testIndividualInsertsMediumSparseRange() throws ExecutionException, InterruptedException | |||
{ | |||
testInsertions(randomSeed(), perThreadTrees / 10, 500, 10, 1, true); | |||
testInsertions(randomSeed(), 500, 10, 1, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I think we can safely increase the number of local runs for testLargeBatchesLargeRange
, and testIndividualInsertsMediumSparseRange
while still maintaining a reasonable execution time for the LongBTreeTest as a whole.
For the tests that fire testInsertions
with parameters the main concern we have is - we perform different numbers of test attempts to check tree insertions for variations of ranges and batches, but the same equal number of tests
should be used for all of them. I think perThreadTrees * threads
is the better choice for us since increasing the perThreadTrees
(for testInsertions
it's not exactly trees per thread as it says, it's just a multiplier) will give us the ability to find patterns e.g. for a heap consumption during a particular run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also possible to just set the perThreadTrees
for 10000 back to 100 as an easy fix, I guess. I just wanted to fix the problem wider and maybe I overdid it :-)
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira