Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-18305 trunk Enhance nodetool compactionstats with existing MBean metrics #2333

Closed
wants to merge 4 commits into from
Closed

CASSANDRA-18305 trunk Enhance nodetool compactionstats with existing MBean metrics #2333

wants to merge 4 commits into from

Conversation

mghildiy
Copy link
Contributor

@mghildiy mghildiy commented May 14, 2023 •
edited 

Enhance nodetool compactionstats with existing MBean metrics

Print some more metrics related to compaction:

- Compactions completed, and different meter rates
- Concurrent compactors
- compactions completed
- data compacted
- compactions aborted
- compactions reduced

patch by @mghildiy

The Cassandra Jira

@Mmuzaf
Copy link
Contributor

Mmuzaf commented May 19, 2023

@driftx @mghildiy

I noticed that CompactionStatsTest#testCompactionStats checks the output of the command. Should we also improve the test coverage to be sure that new metrics are present in the command output?

@mghildiy
Copy link
Contributor Author

mghildiy commented May 22, 2023 •
edited

@driftx @mghildiy

I noticed that CompactionStatsTest#testCompactionStats checks the output of the command. Should we also improve the test coverage to be sure that new metrics are present in the command output?

@Mmuzaf, I would look into it.

@mghildiy
Copy link
Contributor Author

Updated test.

@smiklosovic smiklosovic changed the title CASSANDRA-18305: Enhance nodetool compactionstats with existing MBean metrics CASSANDRA-18305 trunk Enhance nodetool compactionstats with existing MBean metrics Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftx driftx driftx requested changes

@smiklosovic smiklosovic smiklosovic left review comments

@Maxwell-Guo Maxwell-Guo Maxwell-Guo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@mghildiy @Mmuzaf @driftx @smiklosovic @Maxwell-Guo