CASSANDRA-18305 4.0 - Enhance nodetool compactionstats #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maxwell-Guo
reviewed
Jun 5, 2023
src/java/org/apache/cassandra/tools/nodetool/CompactionStats.java
Outdated
Show resolved
Hide resolved
| for (Entry<String, Integer> tableEntry : ksEntry.getValue().entrySet()) | ||
| numTotalPendingTask += tableEntry.getValue(); | ||
| { | ||
| toPrint.append("- " + ksName + '.' + tableEntry.getKey() + ": " + tableEntry.getValue()); |
There was a problem hiding this comment.
should we use String format?
There was a problem hiding this comment.
Looks like this was missed?
There was a problem hiding this comment.
This is not latest. Tablebuilder is used in latest changes. I pushed those changes few days back. I am not aure why they are not visible. Let me check.
There was a problem hiding this comment.
I see, the other commit is on top of this one, okay, that works.
smiklosovic
changed the title
driftx
requested changes
Jun 12, 2023
| for (Entry<String, Integer> tableEntry : ksEntry.getValue().entrySet()) | ||
| numTotalPendingTask += tableEntry.getValue(); | ||
| { | ||
| toPrint.append("- " + ksName + '.' + tableEntry.getKey() + ": " + tableEntry.getValue()); |
There was a problem hiding this comment.
Looks like this was missed?
Maxwell-Guo
reviewed
Jun 13, 2023
| Map<String, Map<String, Integer>> pendingTaskNumberByTable = | ||
| (Map<String, Map<String, Integer>>) probe.getCompactionMetric("PendingTasksByTableName"); | ||
| int numTotalPendingTask = 0; | ||
| (Map<String, Map<String, Integer>>) probe.getCompactionMetric("PendingTasksByTableName"); |
There was a problem hiding this comment.
Shouldn't the 4 spaces be removed at the beginning of line 65?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cassandra Jira