Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-18555 expose failed decommission via nodetool info #2390

Closed
wants to merge 1 commit into from
Closed

CASSANDRA-18555 expose failed decommission via nodetool info #2390

wants to merge 1 commit into from

Conversation

smiklosovic
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@smiklosovic smiklosovic force-pushed the CASSANDRA-18555 branch 8 times, most recently from 9c67c26 to 7324b58 Compare June 7, 2023 20:41
@smiklosovic smiklosovic force-pushed the CASSANDRA-18555 branch 2 times, most recently from 6971ae8 to 3b3d9d1 Compare June 12, 2023 11:06
@smiklosovic smiklosovic force-pushed the CASSANDRA-18555 branch 9 times, most recently from ddf146e to 92d295b Compare June 17, 2023 11:20
driftx
driftx reviewed Jun 20, 2023
View reviewed changes
src/java/org/apache/cassandra/service/StorageService.java Show resolved Hide resolved
src/java/org/apache/cassandra/service/StorageService.java Outdated Show resolved Hide resolved
src/java/org/apache/cassandra/service/StorageService.java Outdated
{
int rf, numNodes;
for (String keyspaceName : Schema.instance.getNonLocalStrategyKeyspaces().names())
{
if (!force)
{
boolean throwException = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we name this more descriptively, like 'sufficientNodes' or something?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to notEnoughLiveNodes

@smiklosovic smiklosovic changed the title CASSANDRA-18555 expose failed decommission via system.local CASSANDRA-18555 expose failed decommission via nodetool info Jun 20, 2023
@smiklosovic smiklosovic force-pushed the CASSANDRA-18555 branch 3 times, most recently from 124c4ae to 95f53c9 Compare June 20, 2023 15:09
@smiklosovic @jaydeepkumar1984
Expose decommission state to nodetool info
3a7d47a 
patch by Stefan Miklosovic; reviewed by Brandon Williams CASSANDRA-18555

Co-authored-by: Jaydeepkumar Chovatia <chovatia.jaydeep@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driftx driftx driftx left review comments

@Maxwell-Guo Maxwell-Guo Maxwell-Guo approved these changes

@bereng bereng Awaiting requested review from bereng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@smiklosovic @driftx @Maxwell-Guo @bereng