Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASSANDRA-18646 Azure snitch #2462

Closed
wants to merge 2 commits into from
Closed

CASSANDRA-18646 Azure snitch #2462

wants to merge 2 commits into from

Conversation

smiklosovic
Copy link
Contributor

Thanks for sending a pull request! Here are some tips if you're new here:

  • Ensure you have added or run the appropriate tests for your PR.
  • Be sure to keep the PR description updated to reflect all changes.
  • Write your PR title to summarize what this PR proposes.
  • If possible, provide a concise example to reproduce the issue for a faster review.
  • Read our contributor guidelines
  • If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

@smiklosovic smiklosovic force-pushed the CASSANDRA-18646 branch 8 times, most recently from 63c7ca7 to a62ee0b Compare July 3, 2023 14:33
@smiklosovic smiklosovic marked this pull request as ready for review July 3, 2023 14:34
@smiklosovic smiklosovic changed the title CASSANDRA-18646 CASSANDRA-18646 Azure snitch Jul 3, 2023
@smiklosovic smiklosovic force-pushed the CASSANDRA-18646 branch 2 times, most recently from 24918fb to dd1972e Compare July 10, 2023 11:45
@smiklosovic smiklosovic force-pushed the CASSANDRA-18646 branch 2 times, most recently from 5ca583b to c66e655 Compare July 13, 2023 13:09
xgerman
xgerman approved these changes Jul 14, 2023
View reviewed changes
conf/cassandra.yaml Outdated Show resolved Hide resolved
@smiklosovic smiklosovic force-pushed the CASSANDRA-18646 branch 4 times, most recently from d3ab855 to da4bd54 Compare July 16, 2023 16:29
@smiklosovic smiklosovic force-pushed the CASSANDRA-18646 branch 4 times, most recently from cd9a31d to a0ddf49 Compare July 17, 2023 14:14
jacek-lewandowski
jacek-lewandowski approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@jacek-lewandowski jacek-lewandowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, please make sure CI is passing before merge

conf/cassandra.yaml Show resolved Hide resolved
@smiklosovic
Add AzureSnitch
c273017 
As we were implementing the snitch itself, we noticed that the constructors
for cloud-based snitches are unnecessarilly complicated and
we took the opportunity to make them simpler.

patch by Stefan Miklosovic; reviewed by German Eichberger and Jacek Lewandowski for CASSANDRA-18646
@smiklosovic
DO NOT COMMIT
8a79e63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacek-lewandowski jacek-lewandowski jacek-lewandowski approved these changes

@xgerman xgerman xgerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@smiklosovic @jacek-lewandowski @xgerman