Replicalayout followup #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, resulting in timeout instead of overload
aweisberg
reviewed
Sep 10, 2018
| ReplicaLayout.ForTokenWrite liveAndDown = ReplicaLayout.forTokenWriteLiveAndDown(keyspace, tk); | ||
| Replicas.temporaryAssertFull(liveAndDown.all()); // TODO in CASSANDRA-14549 | ||
|
|
||
| EndpointsForToken.Builder liveReplicasBuilder = EndpointsForToken.builder(tk); | ||
| Replica selfReplica = liveAndDown.all().selfIfPresent(); | ||
| if (selfReplica != null) |
There was a problem hiding this comment.
What exactly is this corner case where we have a hint written to ourselves? I thought we don't hint ourselves.
There was a problem hiding this comment.
Looked at mutateAtomically and sendToHintedEndpoints, I guess I can see that we do have the batch log attempt to write to the coordinator. I guess that sort of makes sense in the batch log doesn't really make sense sort of way. It's possible the coordinator didn't hand the write off to itself.
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Oct 11, 2021
…A-16663) (apache#262) Ported from OSS commit d220d24.
jacek-lewandowski
pushed a commit
to jacek-lewandowski/cassandra
that referenced
this pull request
Mar 7, 2022
…A-16663) (apache#262) Ported from OSS commit d220d24. (cherry picked from commit b762e3c)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Mar 21, 2022
…A-16663) (apache#262) Ported from OSS commit d220d24. (cherry picked from commit b762e3c)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jun 13, 2022
…A-16663) (apache#262) Ported from OSS commit d220d24. (cherry picked from commit b762e3c) (cherry picked from commit 34374c1)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 24, 2022
…A-16663) (apache#262) Ported from OSS commit d220d24. (cherry picked from commit b762e3c) (cherry picked from commit 34374c1) (cherry picked from commit b9046be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.