New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

14726 #271

Closed

belliottsmith wants to merge 8 commits into apache:trunk from belliottsmith:14726

Contributor

belliottsmith commented Sep 18, 2018

No description provided.

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Outdated Show resolved Hide resolved

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/EndpointsForRange.java Show resolved Hide resolved

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/EndpointsForRange.java Outdated Show resolved Hide resolved

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/EndpointsForToken.java Outdated Show resolved Hide resolved

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/EndpointsForToken.java Outdated Show resolved Hide resolved

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/RangesAtEndpoint.java Outdated Show resolved Hide resolved

aweisberg reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/ReplicaMultimap.java Show resolved Hide resolved

ifesdjeen reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Outdated Show resolved Hide resolved

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Outdated Show resolved Hide resolved

src/java/org/apache/cassandra/locator/EndpointsByRange.java Outdated Show resolved Hide resolved

src/java/org/apache/cassandra/locator/EndpointsForRange.java Outdated Show resolved Hide resolved

src/java/org/apache/cassandra/locator/Endpoints.java Outdated

@@ @@ -36,13 +33,16 @@ @@
                */
               public abstract class Endpoints<E extends Endpoints<E>> extends AbstractReplicaCollection<E>
               {
-                  static final Map<InetAddressAndPort, Replica> EMPTY_MAP = Collections.unmodifiableMap(new LinkedHashMap<>());
+                  static final ReplicaMap<InetAddressAndPort> endpointMap(ReplicaList list) { return new ReplicaMap<>(list, Replica::endpoint); }

Contributor

ifesdjeen Sep 27, 2018

This is a method, we can skip final here

test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java Show resolved Hide resolved

test/unit/org/apache/cassandra/locator/ReplicaCollectionTest.java Outdated Show resolved Hide resolved

src/java/org/apache/cassandra/locator/ReplicaMultimap.java Show resolved Hide resolved

ifesdjeen reviewed

View reviewed changes

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Show resolved Hide resolved

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Show resolved Hide resolved

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Show resolved Hide resolved

src/java/org/apache/cassandra/locator/AbstractReplicaCollection.java Show resolved Hide resolved

belliottsmith added 8 commits

October 1, 2018 10:30


          introduce ReplicaList and ReplicaMap inner classes

6c1ca05


          cleanup RangesAtEndpoint transient/full cached filtering; use whereve…

fbdbd67

…r possible


          circleci

0a02d94


          small cleanup + comments

78e5e6c


          Remove Mutable, asImmutableView/asSnapshot etc.; use only Builder and…

ce4f0cc

… build()


          minor cleanup

106ea01


          improve tests; remove unnecessary Collections.unmodifiableMap calls /…

299df9d

… method overrides


          address review comments

5b41c59

belliottsmith force-pushed the 14726 branch from 7a24798 to 5b41c59 Compare

October 1, 2018 09:37

belliottsmith force-pushed the trunk branch from 822ea57 to 16ef9ac Compare

February 8, 2019 17:46

iamaleksey force-pushed the trunk branch from 532c033 to 0d48503 Compare

June 12, 2019 15:27

belliottsmith force-pushed the trunk branch from d0be441 to 7dc5b70 Compare

August 20, 2019 15:11

blambov pushed a commit to blambov/cassandra that referenced this pull request


          STAR-891 Add pluggable disk/commit log error handlers and shutdown ho…

c6cd4ee

…oks (apache#271)

jacek-lewandowski pushed a commit to jacek-lewandowski/cassandra that referenced this pull request


          STAR-891 Add pluggable disk/commit log error handlers and shutdown ho…

884fc6a

…oks (apache#271)

(cherry picked from commit c6cd4ee)

smiklosovic closed this

blambov pushed a commit to blambov/cassandra that referenced this pull request


          STAR-891 Add pluggable disk/commit log error handlers and shutdown ho…

ae8e02b

…oks (apache#271)

(cherry picked from commit c6cd4ee)

blambov pushed a commit to blambov/cassandra that referenced this pull request


          STAR-891 Add pluggable disk/commit log error handlers and shutdown ho…

f7f8e0a

…oks (apache#271)

(cherry picked from commit c6cd4ee)
(cherry picked from commit fb5c241)

blambov pushed a commit to blambov/cassandra that referenced this pull request


          STAR-891 Add pluggable disk/commit log error handlers and shutdown ho…

0ff7339

…oks (apache#271)

(cherry picked from commit c6cd4ee)
(cherry picked from commit fb5c241)
(cherry picked from commit f7f8e0a)

adelapena pushed a commit to adelapena/cassandra that referenced this pull request


          STAR-891 Add pluggable disk/commit log error handlers and shutdown ho…

07cd5c9

…oks (apache#271)

(cherry picked from commit c6cd4ee)
(cherry picked from commit fb5c241)
(cherry picked from commit f7f8e0a)
(cherry picked from commit 0ff7339)
(cherry picked from commit e7ca94c)

STAR-891 Fix conflict in DiskFailurePolicyTest with CASSANDRA-18294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment