CASSANDRA-18876 5.0: Vector type shouldn't support empty value #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcapwell
approved these changes
Sep 25, 2023
Maxwell-Guo
approved these changes
Sep 27, 2023
|
Thanks for the review. I have added an explicit exception about the empty/null value in those places where we used to manage the empty values. The error message is simply |
dcapwell
approved these changes
Sep 27, 2023
adelapena
force-pushed
the
18876-5.0
branch
4 times, most recently
from
fd12e8d
to
0f5d1a9
Compare
patch by Andrés de la Peña; reviewed by David Capwell and Maxwell Guo for CASSANDRA-18876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.