CASSANDRA-19015 Nodetool 'tablestats' formatting uses inconsistent significant digits #2919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Nodetool reports milliseconds (ms) with anywhere from 3 to 15 significant digits. Ratios use five or sixteen decimal places. Averages use 1 or 13 decimal places.
Example:
After
Milliseconds use 3 decimal places
Ratios use 3 decimal places (tenths of a percent)
Averages use 2 decimal places
Example:
How to reproduce
nodetool tablestats
Tests
ant testsome -Dtest.name=org.apache.cassandra.utils.FBUtilitiesTest
ant testsome -Dtest.name=org.apache.cassandra.tools.nodetool.stats.TableStatsPrinterTest
ant testsome -Dtest.name=org.apache.cassandra.tools.nodetool.TableStatsTest
patch by @zaaath; reviewed by @smiklosovic for CASSANDRA-19015