Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSANDRA-19110 convert deprecated apt-key command to new method on deb systems #2936

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

zyxep
Copy link

@zyxep zyxep commented Nov 28, 2023

Hi,

I've updated the 2 shell scripts that generates the output for Debian based systems.
since apt-key is deprecated and getting removed soon then I suggest on moving to the "new" way with gpg --dearmor method and pointing the apt source to the new file.

I've pointed the source of the gpg key to /etc/apt/keyrings because /usr/share/keyrings/ is also getting converted.
On Ubuntu 22.04 a default folder /etc/apt/keyrings is created but not on 20.04 hence my comment in that shell script.

There are no output of gpg --dearmor so I have not updated add_repo_keys.result

I've also updated the deb line in get_deb_packages.sh to use signed gpg key since apt is starting to require keys like that.

Switched from outdated / deprecated apt-key add to gpg --dearmor
updated get deb package to use new signed key
@smiklosovic
Copy link
Contributor

Hi @zyxep , I am just checking if this has a corresponding JIRA ticket?

@smiklosovic
Copy link
Contributor

Aha I see, this is just about the documentation ...

@smiklosovic
Copy link
Contributor

@driftx does this make sense to you? I think you are more fit to review this.

@driftx
Copy link
Contributor

driftx commented Nov 29, 2023

@smiklosovic smiklosovic changed the title convert deprecated apt-key command to new method on deb systems CASSANDRA-19110 convert deprecated apt-key command to new method on deb systems Nov 29, 2023
@zyxep
Copy link
Author

zyxep commented Nov 30, 2023

Ya, only documentation :)
I tried to find _/download docs but wasn't able to find it, maybe it just uses the same shell scripts to compile it's data from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants