Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASSANDRA-18232: CEP-26 Rewrite compaction information, updating LCS, STSC, TWCS, and adding … #2973

Closed
wants to merge 1 commit into from

Conversation

polandll
Copy link
Contributor

@polandll polandll commented Dec 7, 2023

Resubmitting

@polandll polandll changed the title Rewrite compaction information, updating LCS, STSC, TWCS, and adding … CASSANDRA-18232: CEP-26 Rewrite compaction information, updating LCS, STSC, TWCS, and adding … Dec 7, 2023
@polandll polandll added the docs label Dec 7, 2023
…UCS. Adding more UCS text and images, and fixing stem. Sneak in sai partial about sai only supporting UPDATE or DELETE. Add a note about vector max limit. Switch syntax for overused variables. Add info on edge cases for S.

Submitted by Lorina Poland, source from Branimir Lambov; Reviewed by Mick Semb Wever for CASSANDRA-18232
Comment on lines +220 to +224
* big (3.0.0): literally BigTable format

=== Version 5

* bti (5.0.0): Big Trie format
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on a fix for this…

provide highly available global semantics. For example Cassandra does
not support:
provide highly available global semantics.
For example, {cassandra} does not support:

* Cross-partition transactions
* Distributed joins
* Foreign keys or referential integrity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later on, it might be worth adding a sentence here that this changes in 5.1 with Accord ACID transactions

`max_mutation_size` is a half the size of `commitlog_segment_size`.
== Logging writes to commit logs

When a write occurs, {cassandra} writes the data to a local append-only https://cassandra.apache.org/_/glossary.html#commit-log[commit log] on disk.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, and below, a few links need fixing. working on it…

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

** `periodic`: In periodic mode, writes are immediately ack'ed, and the
CommitLog is simply synced every "commitlog_sync_period"
milliseconds.
** `periodic`: In periodic mode, writes are immediately acknowledged, and the commit log is simply synced every "commitlog_sync_period" milliseconds.
+
- `commitlog_sync_period`: Time to wait between "periodic" fsyncs
_Default Value:_ 10000ms
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for later, these default value lines are not indented, so it doesn't read easy

@@ -4,6 +4,8 @@
The xref:cassandra:getting-started/sai-quickstart.adoc[SAI quickstart] focuses only on defining multiple indexes based on non-primary key columns (a very useful feature).
Let's explore other options using some examples of how you can run queries on tables that have differently defined SAI indexes.

include::developing:partial$sai/sai-only-select.adoc[]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working, any suggestions @polandll ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see includes being used on adoc files anywhere else … ? 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later

@@ -0,0 +1,235 @@
= Compaction overview
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do the breadcrumbs work on the index.adoc but not this page or any of the other subpages ?
Screenshot 2023-12-08 at 20 33 02

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file about ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

Comment on lines +3 to +4
* xref:cassandra:managing/operating/auditlogging.adoc[Audit logging]
* xref:cassandra:managing/operating/audit_logging.adoc[Audit logging 2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not part of this review, but why are there two audit logging pages ?

@michaelsembwever
Copy link
Member

Committed as 93a4fcd

@polandll polandll deleted the CEP-26-clean branch January 4, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants