Add a startup check to fail startup when using invalid configuration … #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-lewandowski
force-pushed
the
CASSANDRA-19196
branch
from
9e1c640
to
438ae75
Compare
Maxwell-Guo
reviewed
Dec 20, 2023
| @@ -616,10 +619,9 @@ public enum CassandraRelevantProperties | |||
| USE_NIX_RECURSIVE_DELETE("cassandra.use_nix_recursive_delete"), | |||
| /** Gossiper compute expiration timeout. Default value 3 days. */ | |||
| VERY_LONG_TIME_MS("cassandra.very_long_time_ms", "259200000"), | |||
| WAIT_FOR_TRACING_EVENTS_TIMEOUT_SECS("cassandra.wait_for_tracing_events_timeout_secs", "0"), | |||
| WAIT_FOR_TRACING_EVENTS_TIMEOUT_SECS("cassandra.wait_for_tracing_events_timeout_secs", "0") | |||
There was a problem hiding this comment.
";" should not start a new line
There was a problem hiding this comment.
actually, I'll revert that to its original state
| @@ -1136,6 +1150,41 @@ public static void exec(ProcessBuilder pb) throws IOException | |||
| } | |||
| } | |||
|
|
|||
| public static String exec(Map<String, String> env, Duration timeout, int outBufSize, int errBufSize, String... cmd) throws IOException, TimeoutException, InterruptedException | |||
There was a problem hiding this comment.
trunk 's exec method is different from 5.0 here
no description of the function and lack of some logic
There was a problem hiding this comment.
yes, I forgot to push this and other changes, they should be there now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.