-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CASSANDRA-18714 5.0 squashed SAI indexes for CQLSSTableWriter #3046
CASSANDRA-18714 5.0 squashed SAI indexes for CQLSSTableWriter #3046
Conversation
f6cb601
to
a73d011
Compare
a73d011
to
26ad17e
Compare
{ | ||
if (!entry.left.equals(tableMetadata)) | ||
{ | ||
throw new IllegalStateException(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add exception message
{ | ||
DatabaseDescriptor.daemonInitialization(); | ||
} | ||
private Supplier<CQLSSTableWriter.Builder> defaultBuilderSupplier = () -> CQLSSTableWriter.builder().removeSchemaAfterDone(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private Supplier<CQLSSTableWriter.Builder> defaultBuilderSupplier = () -> CQLSSTableWriter.builder().removeSchemaAfterDone(false); | |
private final Supplier<CQLSSTableWriter.Builder> defaultBuilderSupplier = () -> CQLSSTableWriter.builder().removeSchemaAfterDone(false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM
The only thing I'm not entirely sure of is whether we want the complexity of tracking currentTables
outside the already existing static Schema
state. Given the usage pattern of sequentially creating writers within the same JVM, we might consider an alternative where we just, rather than specifying removeSchemaAfterDone
, tell the writer builder whether we want to overwrite existing/conflicting schema.
Thanks for sending a pull request! Here are some tips if you're new here:
Commit messages should follow the following format:
The Cassandra Jira