CASSANDRA-19336 5.0: Ensure that repair doesn't exceed repair_session_space by running repair jobs sequentially #3073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iting validation parallelism Co-authored-by: Andrés de la Peña <a.penya.garcia@gmail.com> Co-authored-by: David Capwell <dcapwell@apache.org>
dcapwell
reviewed
Feb 5, 2024
| } | ||
| } | ||
|
|
||
| abstract class Task<T> extends AsyncFuture<T> implements Runnable |
There was a problem hiding this comment.
isn't this just org.apache.cassandra.concurrent.FutureTask?
There was a problem hiding this comment.
This is slightly different due to how the run method sets a callback. I have moved the setting of that callback into the Task class to encapsulate it better.
dcapwell
approved these changes
Feb 5, 2024
| }); | ||
| } | ||
| }; | ||
| session.validationScheduler.schedule(session.getId(), taskExecutor, syncTasks); |
There was a problem hiding this comment.
feel its cleaner to return Future<T> from schedule
| } | ||
|
|
||
| @Override | ||
| public synchronized void schedule(TimeUUID sessionId, Executor taskExecutor, Task<?> tasks) |
There was a problem hiding this comment.
the usage is a single task, so all sessions will have the same score... so a simpler data structure could be used... this class makes the most sense when we have way to compare tasks
There was a problem hiding this comment.
I have changed it to a single queue of task-executor pairs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.