CASSANDRA-19477 trunk dont go to disk for hints sizes #3180

smiklosovic · 2024-03-16T22:45:13Z

Thanks for sending a pull request! Here are some tips if you're new here:

Ensure you have added or run the appropriate tests for your PR.
Be sure to keep the PR description updated to reflect all changes.
Write your PR title to summarize what this PR proposes.
If possible, provide a concise example to reproduce the issue for a faster review.
Read our contributor guidelines
If you're making a documentation change, see our guide to documentation contribution

Commit messages should follow the following format:

<One sentence description, usually Jira title or CHANGES.txt summary>

<Optional lengthier description (context on patch)>

patch by <Authors>; reviewed by <Reviewers> for CASSANDRA-#####

Co-authored-by: Name1 <email1>
Co-authored-by: Name2 <email2>

The Cassandra Jira

clohfink · 2024-03-18T22:36:07Z

+1 thanks for this!

src/java/org/apache/cassandra/hints/HintsStore.java

src/java/org/apache/cassandra/hints/HintsWriteExecutor.java

src/java/org/apache/cassandra/hints/HintsStore.java

iamaleksey · 2024-03-19T15:39:31Z

I would just cache the size value in a transient field in HintsDescriptor. A CHM is an overkill here.

src/java/org/apache/cassandra/hints/HintsStore.java

src/java/org/apache/cassandra/hints/HintsWriteExecutor.java

src/java/org/apache/cassandra/hints/HintsWriter.java

smiklosovic · 2024-03-20T11:41:12Z

src/java/org/apache/cassandra/hints/HintsWriter.java

@@ -271,6 +273,7 @@ public void close() throws IOException
            flushBuffer();
            maybeFsync();
            maybeSkipCache();
+            descriptor.size = position();


why not to just update it in close() ? Then when this is used in try-with-resources in HintsWriteExecutor, we do not need to change there anything at all and not mess with finally etc ...

this should be probably in finally though, not sure ... as all above can throw

src/java/org/apache/cassandra/hints/HintsDescriptor.java

patch by Stefan Miklosovic; reviewed by Aleksey Yeschenko, Chris Lohfink for CASSANDRA-19477

smiklosovic force-pushed the CASSANDRA-19477-trunk branch 11 times, most recently from 5e55b19 to c1db700 Compare March 18, 2024 07:20

smiklosovic commented Mar 19, 2024

View reviewed changes

src/java/org/apache/cassandra/hints/HintsStore.java Outdated Show resolved Hide resolved