CASSANDRA-15125 Replace Math.random with Replace.nextDouble to remo… #320
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve performance overhead
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Feb 15, 2022
jacek-lewandowski
pushed a commit
to jacek-lewandowski/cassandra
that referenced
this pull request
Mar 7, 2022
smiklosovic
changed the title
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jun 13, 2022
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 24, 2022
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ve performance overhead
CASSANDRA-15125 Math.random has a slight performance overhead associated with itself that does not exist in Random.nextDouble. These instances of Math.random, such as those sampled below, can be replaced with random.nextDouble. Furthermore, the randomness can be configured via the Random class if such a feature is needed in the future.