CASSANDRA-19693 Relax slow_query_log_timeout for MultiNodeSAITest #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patch by Caleb Rackliffe; reviewed by Alex Petrov for CASSANDRA-19693
bbotella
reviewed
Jun 10, 2024
| @@ -45,7 +45,10 @@ public static void before() throws Throwable | |||
| cluster = Cluster.build() | |||
| .withNodes(2) | |||
| // At lower fetch sizes, queries w/ hundreds or thousands of matches can take a very long time. | |||
| .withConfig(InJvmSutBase.defaultConfig().andThen(c -> c.set("range_request_timeout", "180s").set("read_request_timeout", "180s") | |||
| .withConfig(InJvmSutBase.defaultConfig().andThen(c -> c.set("range_request_timeout", "180s") | |||
There was a problem hiding this comment.
Nit: Maybe worth extracting that 180s to a constant?
There was a problem hiding this comment.
Want to leave some room to change these in the future, as they've been chosen somewhat arbitrarily.
| if (retryStrategy.apply(t)) | ||
| return execute(statement, cl, bindings); | ||
| if (retryStrategy.apply(t)) | ||
| continue; |
There was a problem hiding this comment.
Just a question for my education. Are we not applying some backoff or delay between retries?
There was a problem hiding this comment.
We could apply backoff, but this is an in-jvm test, so the initial thinking was that it's a very controlled environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch by Caleb Rackliffe; reviewed by Alex Petrov for CASSANDRA-19693