Documentation gives the wrong instruction to activate remote jmx (CASSANDRA-15535) #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have committed this change. Please take a look at my comment in the ticket here: https://issues.apache.org/jira/browse/CASSANDRA-15535 For future reference, please don't reuse existing branches or PRs for new fixes. Update your local trunk and create a fresh branch with changes in there. |
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Jun 13, 2022
CompactionOutOfSpaceTest suffered from a race condition where compaction would remove an sstable that was being checked by StartupChecks inside of CassandraDaemon::activate. This was fixed by running activate first, before initializing CqlTester. Explicit registration of CassandraDaemon in StorageService was removed because CassandraDaemon does that itself. (cherry picked from commit 62e012f)
blambov
pushed a commit
to blambov/cassandra
that referenced
this pull request
Nov 24, 2022
CompactionOutOfSpaceTest suffered from a race condition where compaction would remove an sstable that was being checked by StartupChecks inside of CassandraDaemon::activate. This was fixed by running activate first, before initializing CqlTester. Explicit registration of CassandraDaemon in StorageService was removed because CassandraDaemon does that itself. (cherry picked from commit 62e012f) (cherry picked from commit 8b53f40)
adelapena
pushed a commit
to adelapena/cassandra
that referenced
this pull request
Sep 26, 2023
CompactionOutOfSpaceTest suffered from a race condition where compaction would remove an sstable that was being checked by StartupChecks inside of CassandraDaemon::activate. This was fixed by running activate first, before initializing CqlTester. Explicit registration of CassandraDaemon in StorageService was removed because CassandraDaemon does that itself. (cherry picked from commit 62e012f) (cherry picked from commit 8b53f40) (cherry picked from commit de134e5) (cherry picked from commit 64147e9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to activate jmx remote, the varaible LOCAL_JMX has to be set to no, the documentation says the opposite. @dineshjoshi