Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by avoiding string concatenation in a loop using StringBuilder #458

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Improve performance by avoiding string concatenation in a loop using StringBuilder #458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/java/org/apache/cassandra/hadoop/cql3/CqlRecordWriter.java
View file
Open in desktop
Expand Up @@ -474,14 +474,16 @@ private ByteBuffer getPartitionKey(Map<String, ByteBuffer> keyColumns)
*/
private String appendKeyWhereClauses(String cqlQuery)
{
String keyWhereClause = "";
StringBuilder keyWhereClause = new StringBuilder();

keyWhereClause.append(cqlQuery).append(" WHERE ");

for (ColumnMetadata partitionKey : partitionKeyColumns)
keyWhereClause += String.format("%s = ?", keyWhereClause.isEmpty() ? quote(partitionKey.getName()) : (" AND " + quote(partitionKey.getName())));
keyWhereClause.append(String.format("%s = ?", (keyWhereClause.length() == 0) ? quote(partitionKey.getName()) : (" AND " + quote(partitionKey.getName()))));
for (ColumnMetadata clusterColumn : clusterColumns)
keyWhereClause += " AND " + quote(clusterColumn.getName()) + " = ?";
keyWhereClause.append(" AND " + quote(clusterColumn.getName()) + " = ?");

return cqlQuery + " WHERE " + keyWhereClause;
return keyWhereClause.toString();
}

/** Quoting for working with uppercase */
Expand Down