CASSANDRA-15623: cqlsh return non-zero status when STDIN CQL fails #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe currently it can be safely assumed that any `Shell` instance without a TTY (i.e. `Shell.tty == False`) is in a "batch mode". With this in mind, the two following changes were applied. First, while we could just use the `Shell.tty` attribute directly, to be semantically clear and to provide room for future enhancement on what is considered a "batch mode", we will add a respective property instead. Second, with the new `Shell.batch_mode` property at hand, it makes no more sense to check any options implying a "batch mode", it is perfectly enough to just check this property. patch by Jacob Becker a.k.a. plastikat; reviewed by Jordan West for CASSANDRA-15623
This was referenced Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe currently it can be safely assumed that
any
Shellinstance without a TTY (i.e.Shell.tty == False) is in a "batch mode". With this in mind,the two following changes were applied.
First, while we could just use the
Shell.ttyattribute directly, to be semantically clear and to
provide room for future enhancement on what is
considered a "batch mode", we will add a respective
property instead.
Second, with the new
Shell.batch_modeproperty athand, it makes no more sense to check any options
implying a "batch mode", it is perfectly enough to
just check this property.
patch by Jacob Becker a.k.a. plastikat;
reviewed by Jordan West for CASSANDRA-15623