opinion on refactoring ListenableFuture to Java 8 CompletableFuture #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yulin2 Pull requests are not used for Apache Cassandra. Please open a JIRA (https://issues.apache.org/jira/browse/CASSANDRA) if you have an improvement, idea or issue to share and close this request. |
bdeggleston
pushed a commit
to bdeggleston/cassandra
that referenced
this pull request
Dec 11, 2023
Permit the state machine to erase transactions that are known to be applied across the cluster. --------- Co-authored-by: dcapwell <dcapwell@gmail.com> Co-authored-by: Aleksey Yeschenko <aleksey@apache.org> Co-authored-by: Ariel Weisberg <aweisberg@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing research on new concurrent constructs in Java 8. I found
CompletableFuturein Java 8 has the same functionality as GuavaListenableFuture. ButCompletableFutureis much nicer because it comes together with Lambda expression in Java 8, and it is monadic, which makes the code more readable and cleaner. Also, it provides more ways to compose different tasks. Therefore, usingCompletableFutureinstead ofListenableFutureis better for future extension and maintenance of the code.I tried to refactoring one Guava
ListenableFutureto Java 8CompletableFuturein Cassandra, so you can see the difference in the code. You don't have to merge this pull request. I'm just wondering your opinion on this kind of refactoring (or migrating the code from Java 7 to Java 8). Do you think the refactoring is useful? Do you have any plan to use Java 8?