CASSANDRA-16012 sstablesplit tool unit testing

[bereng]

No description provided.

[bereng]

CI

• j11
• j8

[bereng]

CI j11
CI j8

[bereng]

Well that was a surprise @yifan-c The new custom junit executor was wrong. Adding that new test method you suggested I noticed I couldn't get any failures. The tests were green despite I knew they were broken. I found out the new executor was swallowing all errors. So I removed that and overrode the @After method, which on retrospect I don't know how I didn't think of it before.

Now everything works as expected, it's cleaner and has the extra test method.

CI j11
CI j8

[yifan-c]

Yeah. Like the overriding approach better. It's cleaner.

So.. in order to make the custom runner correctly ignores After or so and not swallow errors, the override need to just return the input statement. In the super class, the runner detects if after exists and run.

        @Override
        protected Statement withAfters(FrameworkMethod method, Object target, Statement statement)
        {
            return statement;
        }

[bereng]

Latest review comments pushed. Thx.

[bereng]

CI for latest force push here