New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAUSEWAY-3409: Mixed in members might have the wrong domain-event type associated #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andi-huber
force-pushed
the
3409-mixin.eventtypes
branch
2 times, most recently
from
April 17, 2023 06:46
77fab68
to
816cbfe
Compare
receive the actual mixee during MM postprocessing and in turn hold the correct event-type (which for mixed in members might need to be looked up on the mixee type)
andi-huber
force-pushed
the
3409-mixin.eventtypes
branch
from
April 17, 2023 07:04
e718cfa
to
64595ef
Compare
PropertySetterOrClearFacetForDomainEventAbstract
FacetFactoryTestAbstract
ActionSemanticsFacetFallbackToNonIdempotentFactoryTest
ObjectSupportFacetFactoryTestAbstract
CallbackFacetFactoryTestAbstract
PropertyAnnotationWithSnapshotOnPropertyFacetFactoryTest
PropertyOptionalityOrNullableAnnotationOnPropertyFacetFactoryTest
ParameterOptionalityOrNullableAnnotationOnParameterFacetFactoryTest
- still WIP but some fixes already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DomainEventFacetAbstract
Deferred to later
@Property
annotation on mixin type (vs on mixin method) not handled@Collection
annotation on mixin type (vs on mixin method) not handled