Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAUSEWAY-3409: Mixed in members might have the wrong domain-event type associated #1583

Merged
merged 37 commits into from Apr 18, 2023

Conversation

andi-huber
Copy link
Contributor

@andi-huber andi-huber commented Apr 15, 2023

  • introduce a new common ancestor for all event-type related facets: DomainEventFacetAbstract
  • refactor the DomainEventFacetAbstract such, that it can receive the actual mixee during MM postprocessing and in turn hold the correct event-type (which for mixed in members might need to be looked up on the mixee type)

Deferred to later

  • test mixin cases for actions
  • test mixin cases for collections
  • test mixin cases for properties
  • @Property annotation on mixin type (vs on mixin method) not handled
  • @Collection annotation on mixin type (vs on mixin method) not handled
  • 'executing' and 'executed' not handled when mixed-in
  • investigate, whether we need the same strategy for thy lifecycle-event related facets

@andi-huber andi-huber self-assigned this Apr 15, 2023
@andi-huber andi-huber added the bug label Apr 15, 2023
@andi-huber andi-huber force-pushed the 3409-mixin.eventtypes branch 2 times, most recently from 77fab68 to 816cbfe Compare April 17, 2023 06:46
@andi-huber andi-huber marked this pull request as ready for review April 18, 2023 15:48
@andi-huber andi-huber merged commit 434de49 into master Apr 18, 2023
3 checks passed
@andi-huber andi-huber deleted the 3409-mixin.eventtypes branch April 19, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant