CAUSEWAY-3409: Part 2 of Mixed in members might have the wrong domain-event type associated #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
andi-huber
commented
Apr 19, 2023
•
andi-huber
commented
- cleanup the meta-model facet factory test hierarchy
- test mixin cases for actions
- test mixin cases for collections
- test mixin cases for properties
- @Property annotation on mixin type (vs on mixin method) not handled
- @Collection annotation on mixin type (vs on mixin method) not handled
- 'executing' and 'executed' not handled when mixed-in
- investigate, whether we need the same strategy for thy lifecycle-event related facets
ActionAnnotationFacetFactoryTest_ActionInvocation
- resurrect FacetAbstractTest - resurrect DomainServiceFacetAnnotationFactoryTest - resurrect DomainServiceLayoutFacetFactoryTest - resurrect LabelAtFacetForParameterLayoutAnnotationFactoryTest - resurrect NamedFacetForParameterLayoutAnnotationFactoryTest
DomainEventFacetAbstract
- do the heavy lifting regarding property execution in the member-execution-service not the PropertySetterOrClearFacetForDomainEventAbstract
- do the heavy lifting regarding action invocation in the member-execution-service not the ActionInvocationFacets
report its facet values
setting and vice versa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.