Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAUSEWAY-2646: Change layout namespaces bs3->bs #1754

Merged
merged 5 commits into from Jun 23, 2023

Conversation

andi-huber
Copy link
Contributor

@andi-huber andi-huber commented Jun 23, 2023

Goals

  • layout files
  • adoc mention

Non Goals

  • rename schema URI

@andi-huber andi-huber self-assigned this Jun 23, 2023
@danhaywood
Copy link
Contributor

@andi-huber ... for the legacy builds, though, can we revert the namespace back to whatever it used to be?

@andi-huber
Copy link
Contributor Author

@danhaywood - I believe what I'm doing here is non invasive. Meaning it should not affect existing code ...

old

xmlns:bs3="https://causeway.apache.org/applib/layout/grid/bootstrap3"

new

xmlns:bs="https://causeway.apache.org/applib/layout/grid/bootstrap3"

Agreed? (I might be wrong.)

@andi-huber andi-huber marked this pull request as ready for review June 23, 2023 14:50
@andi-huber andi-huber merged commit f59bed4 into master Jun 23, 2023
4 checks passed
@andi-huber andi-huber deleted the 2646-rename.bs3.to.bs branch June 23, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants