Name generation refactoring #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Make Smart and Base naming strategies independent in order to make behavior of Smart strategy consistent in all cases 2) Rename NamingStrategy to NameGenerator 3) Split NamedObjectFactory into 3.1) NameChecker which responsible for checking is name available in naming context i.e. EntityAttribute name within Entity 3.2) UniqueNameGenerator which in charge of returning unique name within passed naming context 4) refactor copy/past action in order to use introduced mechanism for name generation 5) move all classes responsible for name generation and checking into "naming" package
behavior of Smart strategy consistent in all cases 2) Rename NamingStrategy to NameGenerator 3) Split NamedObjectFactory into 3.1) NameChecker which responsible for checking is name available in naming context i.e. EntityAttribute name within Entity 3.2) UniqueNameGenerator which in charge of returning unique name within passed naming context 4) refactor copy/past action in order to use introduced mechanism for name generation 5) move all classes responsible for name generation and checking into "naming" package
|
Opened a Jira for it - CAY-1942 https://issues.apache.org/jira/browse/CAY-1942 |
|
Applied. I did some cleanup per bd22051 , but nothing major, mostly cosmetics and licensing. You can close the pull request. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name generation refactoring: …
3.1) NameChecker which responsible for checking is name available in naming context i.e. EntityAttribute name within Entity
3.2) UniqueNameGenerator which in charge of returning unique name within passed naming context