ServerModule conversion to extender API #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ServerModuleExtender * Switching ServerModule to use the extender internally * Updating other modules and tests that relied on ServerModule.contributeXyz API * JCacheModuleExtender
* ProjectModule extender * Extender note on CgenModule
|
still working on this. removing the draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first cut of the https://issues.apache.org/jira/browse/CAY-2772 feature (extender API). I converted
ServerModule,JCacheModuleandProjectModule. The PR is internally consistent, and can be merged as is. The new API even improves the internal Cayenne configuration code. Still, there are some TODOs to finalize CAY-2772 scope:ServerRuntimeBuilderforServerModuleExtender(I think yes).