Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1258] Separate application auth and general metadata and add UserIdentifier to the master application meta #2420

Closed
wants to merge 5 commits into from

Conversation

turboFei
Copy link
Member

@turboFei turboFei commented Mar 26, 2024

What changes were proposed in this pull request?

In this pr, we support to update the user identifier in application meta when initializing lifecycle manager.

To make it clear, we Separate application auth and general metadata.

Why are the changes needed?

to close CELEBORN-1285

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT.

.categories("master")
.doc("Number of threads used by the Master to send ApplicationMeta to Workers.")
.doc("Number of threads used by the Master to send ApplicationAuthMeta to Workers.")
Copy link
Member Author

@turboFei turboFei Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced all the case sensitive keywords in IDEA.

ApplicationMeta -> ApplicationAuthMeta
applicationMeta -> applicationAuthMeta
APPLICATION_META -> APPLICATION_AUTH_META

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Apr 17, 2024
@turboFei turboFei closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant