Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pubsub] pubsub examples for zmq and tcpadmin are not working on develop #190

Closed
rbulter opened this issue Apr 9, 2020 · 9 comments
Closed

[pubsub] pubsub examples for zmq and tcpadmin are not working on develop #190

rbulter opened this issue Apr 9, 2020 · 9 comments
Labels
component/pubsub Categorizes an issue or PR as relevant to pubsub. kind/bug Categorizes issue or PR as related to a bug.

Comments

@rbulter
Copy link
Contributor

rbulter commented Apr 9, 2020 •
edited
Loading

The pubsub examples for zmq and tcpadmin are not working on develop.

The publisher component that request the pubsub publisher service using a default score,
but does not get the service.
@rlenferink rlenferink added component/pubsub Categorizes an issue or PR as relevant to pubsub. kind/bug Categorizes issue or PR as related to a bug. labels Apr 9, 2020
@rbulter
Copy link
Contributor Author

rbulter commented Apr 14, 2020 via email

@abroekhuis
Copy link
Contributor

Hi, I have seen issues with the scope in both ZMQ and TCPadmin. I think this is related to the changes make in scoping. Greetings, Roy

Can you give a bit more info?

@abroekhuis
Copy link
Contributor

There's currently numerous issues with ZMQ in celix, I'm hijacking this comment for now. If desired, we can split it off to several issues.

Found a heap after use error with the pubsub_zmq_zerocopy_test:

Zerocopy test is disabled on purpose, that solution is experimental, and not yet done. @pnoltes knows how/why. I didn't put to much time in it, but if we can easily fix those problems, let's do so!

@rbulter
Copy link
Contributor Author

rbulter commented Apr 14, 2020

zerocopy is not the issue, i am not using this.
The Zmq and TcpAdmin examples are both not running because of the same issue.
The publisher example component tries to get the pubsub publisher service using
a filter. The publisher example component does not get the pubsub publisher service.
The problem is the same for ZMQ and TcpAdmin.

code from ps_pub_activator.c:

    celix_service_tracking_options_t opts = CELIX_EMPTY_SERVICE_TRACKING_OPTIONS;
    opts.callbackHandle = act->client;
    opts.addWithProperties = publisher_publishSvcAdded;
    opts.removeWithProperties = publisher_publishSvcRemoved;
    opts.filter.serviceName = PUBSUB_PUBLISHER_SERVICE_NAME;
    opts.filter.filter = filter;
    opts.filter.ignoreServiceLanguage = true;
    long trackerId = celix_bundleContext_trackServicesWithOptions(ctx, &opts);

@abroekhuis
Copy link
Contributor

zerocopy is not the issue, i am not using this.
The Zmq and TcpAdmin examples are both not running because of the same issue.
The publisher example component tries to get the pubsub publisher service using
a filter. The publisher example component does not get the pubsub publisher service.
The problem is the same for ZMQ and TcpAdmin.

code from ps_pub_activator.c:

    celix_service_tracking_options_t opts = CELIX_EMPTY_SERVICE_TRACKING_OPTIONS;
    opts.callbackHandle = act->client;
    opts.addWithProperties = publisher_publishSvcAdded;
    opts.removeWithProperties = publisher_publishSvcRemoved;
    opts.filter.serviceName = PUBSUB_PUBLISHER_SERVICE_NAME;
    opts.filter.filter = filter;
    opts.filter.ignoreServiceLanguage = true;
    long trackerId = celix_bundleContext_trackServicesWithOptions(ctx, &opts);

Thanks for the info, let me check if I have some local changes that are missing. For me the zmq example works (both with and without a scope). I can't test the tcp admin on OSX, since it uses epoll. A fix so that kqueue is used in that case would be nice ;).

@abroekhuis
Copy link
Contributor

Adding leaks:

Can you open a new issue? I'll get in contact with @rbulter to get the examples working again.

Thx!

@Oipo
Copy link
Contributor

Oipo commented Apr 14, 2020

Adding leaks:

Can you open a new issue? I'll get in contact with @rbulter to get the examples working again.

Thx!

See #191

@abroekhuis
Copy link
Contributor

I think #192 fixed this issue. Can you confirm @rbulter?

@rbulter
Copy link
Contributor Author

rbulter commented Apr 14, 2020

I agree #192 fixed this issue.

@rbulter rbulter closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/pubsub Categorizes an issue or PR as relevant to pubsub. kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Oipo @abroekhuis @rlenferink @rbulter