Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Workaround for Conan's CMake private linking issue #644

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

PengZheng
Copy link
Contributor

One of our users raised a related issue(#642).
Assuming all use of Celix via Conan will be affected by this issue, I add workaround in our build documentation.

@PengZheng PengZheng linked an issue Sep 18, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #644 (b76315a) into master (e1d7fc1) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #644      +/-   ##
==========================================
- Coverage   81.64%   81.57%   -0.07%     
==========================================
  Files         260      260              
  Lines       34679    34679              
==========================================
- Hits        28313    28290      -23     
- Misses       6366     6389      +23     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@pnoltes pnoltes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PengZheng PengZheng merged commit 91ff81c into master Sep 19, 2023
22 checks passed
@PengZheng PengZheng deleted the hotfix/642-cmake-private-linking-workaround-doc branch September 19, 2023 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conan V2 CMake dependencies
3 participants