Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#509: Remove static dm libs (dm is integral part of framework) #662

Merged
merged 5 commits into from
Oct 7, 2023

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Oct 1, 2023

This PR removes the deprecated dependency manager static libs. This is task in #509.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2023

Codecov Report

Merging #662 (44db263) into master (86379aa) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 44db263 differs from pull request most recent head 955d58f. Consider uploading reports for the commit 955d58f to get more accurate results

@@           Coverage Diff           @@
##           master     #662   +/-   ##
=======================================
  Coverage   81.60%   81.60%           
=======================================
  Files         260      260           
  Lines       34677    34677           
=======================================
+ Hits        28297    28299    +2     
+ Misses       6380     6378    -2     

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pnoltes pnoltes linked an issue Oct 1, 2023 that may be closed by this pull request
42 tasks
@PengZheng PengZheng self-requested a review October 5, 2023 09:09
Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Since we are moving toward 3.0.0, removing Conan options, which is not backward compatible, should be permitted.

@pnoltes pnoltes merged commit d61be60 into master Oct 7, 2023
28 checks passed
@pnoltes pnoltes deleted the feature/509-remove-static-dm-libs branch October 7, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Celix 3.0.0 release
3 participants