hotfix/Revert "Fix linker error caused by private linking of transitive depe… #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndencies." This reverts commit f75a419. Revert "Fix copy error in generate method." This reverts commit 6f147b8. Revert "Fix copy error in generate method." This reverts commit 1db9b85. Revert "Add more tracing to CI." This reverts commit 3b12f3b. Revert "Add more tracing to CI." This reverts commit 2d285da. Revert "Revert "Fix copy error in generate method."" This reverts commit 09cfcae. Revert "Revert "Fix copy error in generate method."" This reverts commit 52eaaf8. Revert "Fix assertion failure when dep.cpp_info.libdir is None." This reverts commit 4d831cc. Revert "Fix assertion failure when dep.cpp_info.libdir is None." This reverts commit fdf96fd. Revert "Fix broken test_package for conan1." This reverts commit acabf59. Revert "Copy dependent libraries in Pythonic way." This reverts commit 3bd5474.
PengZheng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix will cause build failure of our downstream users for unknown reasons.
Note that this is my second try to fix conan-io/conan#7192.
I'll not try again and will wait patiently for the Conan team's official fix to land in Conan 2.0.