This repository has been archived by the owner on May 12, 2021. It is now read-only.
CLIMATE-654 - Clean up duplicate unit conversion code #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Cleanup duplicate unit conversion code in dataset_processor that was introduced in CLIMATE-643. water_flux_unit_conversion is no longer duplicated unnecessarily in variable_unit_conversion. - Factor out temperature_unit_conversion code from variable_unit_conversion. Formatting and isolation now matches that of water_flux_unit_conversion. These are both called from the variable_unit_conversion function so there's a convenient wrapper for this functionality (as was the functionality prior to this refactor).
|
Merged build triggered. Test Failed. |
|
Merged build started. Test Failed. |
|
Merged build finished. Test Passed. |
|
Way to go! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduced in CLIMATE-643. water_flux_unit_conversion is no longer
duplicated unnecessarily in variable_unit_conversion.
variable_unit_conversion. Formatting and isolation now matches that of
water_flux_unit_conversion. These are both called from the
variable_unit_conversion function so there's a convenient wrapper for
this functionality (as was the functionality prior to this refactor).