This repository has been archived by the owner on May 12, 2021. It is now read-only.
CLIMATE-838 - Update configuration files and example scripts to use new DatasetLoader #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| ref_dataset = dsp.temporal_subset(ref_dataset,month_start, month_end,average_each_year) | ||
| for idata,dataset in enumerate(model_datasets): | ||
| model_datasets[idata] = dsp.temporal_subset(dataset,month_start, month_end,average_each_year) | ||
| # TODO: Fully support multiple observation / reference datasets. |
There was a problem hiding this comment.
We need to open another JIRA issue for this.
|
This PR is a major breakthrough in RCMES development. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
DatasetLoaderclass inrun_RCMES.py.run_RCMES.pyto make it more closely conform to PEP8, in particular I made many blocks of code multiline to make them more readable. There is still much more that can be done, but this seems like a good start.DatasetLoader. Also note that new blocks of info for each dataset loader are now denoted by a dash (-) underreferenceandtargets. This will make it easy to use multiple loaders in each file.Note that the capability of handling more than one reference (observation) dataset is still not included, I am saving that for a separate JIRA issue / PR. Right now getting these fundamental changes out of the way and making sure everything else works is a bigger priority.
So far I have only tested these changes for one config file (
RCMES/configuration_files/cordex_AF_prec_subregion_annual_cycle_time_series.yaml). @huikyole, please feel free to make comments and keep me posted here.