CLIMATE-883 - Ensure python 3 builds pass unit tests #416
Conversation
|
Can one of the admins verify this patch? |
|
Restarting because one of the builds failed due to connection issues. |
| @@ -74,7 +79,8 @@ def _make_mask_array(values, parameter_id, parameters_metadata): | |||
| ''' | |||
|
|
|||
| for each in parameters_metadata: | |||
| if each['parameter_id'].encode() == str(parameter_id): | |||
| if str(each['parameter_id']) == str(parameter_id): | |||
| print('ok') | |||
There was a problem hiding this comment.
Can remove this logging @agoodm
|
Fixed. Once again CI build failure seems to be due to connectivity issues, so I will merge later today if no further discussion. |
|
+1 from me On Monday, October 24, 2016, Alex Goodman notifications@github.com wrote:
Lewis |
This PR should solve most of the Python 3 compatibility issues we have been having. The biggest ones remaining are some of our examples as well as
run_RCMES.py. I included a minor hotfix to an issue with that file as well for the sake of ensuring these changes don't break our workflow in Python 2.7.In addition to unit tests, I also ran the podaac example and other than some deprecation warnings, everything seems good.
@lewismc @huikyole please review / comment. I have tested one config file for CORDEX Africa and it worked, but feel free to perform any other tests as you see fit.