Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CLIMATE - 803 Initial Stucture for Handling mask for non-maskedd arrays #506

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

prateekiiest
Copy link
Contributor

As an initial structure I am only including checking the exception and will gradually work upon finding the masked array if the given data set array is not masked

@prateekiiest prateekiiest changed the title CLIMATE - 803 - Initial Stucture for Handling mask for non-maskedd arrays CLIMATE - 803 Initial Stucture for Handling mask for non-maskedd arrays May 26, 2018
@prateekiiest
Copy link
Contributor Author

Can I see an example of a ndarray data set having missing values.
By convention is the missing values represented as None or isnan ?

@prateekiiest
Copy link
Contributor Author

@MichaelArthurAnderson your views?

I have mentioned in the climate issues

@lewismc
Copy link
Member

lewismc commented Jun 4, 2018

Thank you @prateekiiest
Over on Jira this issue was reported by @huikyole, he is on vacation right now but I am sure he can answer your question when he returns.

@lewismc
Copy link
Member

lewismc commented Jun 4, 2018

@prateekiiest once we get an example of ndarray data set having missing values it would be great tp create a unit test for this.

@prateekiiest
Copy link
Contributor Author

Thank you @lewismc for letting me know about it. I look forward to it.

@prateekiiest
Copy link
Contributor Author

prateekiiest commented Jun 14, 2018

Tests seem to fail in case of dependencies netcdf4

@lewismc
Copy link
Member

lewismc commented Jun 14, 2018

@prateekiiest do you mean it seems to fail? Can you elaborate?

@prateekiiest
Copy link
Contributor Author

prateekiiest commented Jun 15, 2018

Oops, sorry I actually meant to say fail. Maybe slipped off.

Actually Travis test fails for py2.7 and py3.5

screenshot 135

May be some dependency issues?

I saw a PR recently related to netcdf4. #507

I am not sure if its related to that.

@lewismc
Copy link
Member

lewismc commented Jun 26, 2018

@huikyole @agoodm can you guys please scope out this PR. Thanks, we are working on the build issues.

@agoodm
Copy link
Member

agoodm commented Jun 26, 2018

Ah, I take it this is why you added cython to the dependencies list @lewismc ? conda has been having all sorts of issues with dependency trees lately, as recently @huikyole and I both discovered that pyyaml wasn't actually being included in RCMES distributions like it was supposed to be. We had to add that dependency explicitly to our builds even though we didn't need to before.

@agoodm
Copy link
Member

agoodm commented Jun 26, 2018

Oh, and please close and reopen the PR @prateekiiest so we can see the build run again.

@prateekiiest
Copy link
Contributor Author

ok, @agoodm

@prateekiiest
Copy link
Contributor Author

@lewismc still fails for pydap as in the other PR #503

@lewismc
Copy link
Member

lewismc commented Jun 27, 2018

Hi @prateekiiest please close and reopen again, I added netcdftime to the build profiles

@prateekiiest
Copy link
Contributor Author

@huikyole could you please look into the present approach?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants