CLIMATE-466 update plotter for bettwe color bar. #67
Conversation
Merged build triggered. Test Failed. |
Merged build started. Test Failed. |
Merged build finished. Test Passed. |
mx = mstats.scoreatpercentile(data, 95) | ||
#if there min less than 0 then | ||
#put 0 in center of color bar | ||
if mn < 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be changed to
if mn < 0 and mx > 0:
because otherwise you will end up centering the contours at 0 when the maximum value is negative. This results in superfluous contour levels.
Alex, I thought we never going to have all negative values. |
Hi Mazi, I don't think there is a reason to assume that the values will never be negative. I recommend implementing the change I suggested anyway since it is very simple and gives the same result when the minimum is negative and the maximum is positive. |
👍 to that Alex. Cheers for checking this. |
Merged build triggered. Test Failed. |
Merged build started. Test Failed. |
Merged build finished. Test Passed. |
No description provided.