Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CLIMATE-466 update plotter for bettwe color bar. #67

Closed
wants to merge 3 commits into from

Conversation

MBoustani
Copy link
Contributor

No description provided.

@OCWJenkins
Copy link

Merged build triggered. Test Failed.

@OCWJenkins
Copy link

Merged build started. Test Failed.

@OCWJenkins
Copy link

Merged build finished. Test Passed.

mx = mstats.scoreatpercentile(data, 95)
#if there min less than 0 then
#put 0 in center of color bar
if mn < 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be changed to

if mn < 0 and mx > 0:

because otherwise you will end up centering the contours at 0 when the maximum value is negative. This results in superfluous contour levels.

@MBoustani
Copy link
Contributor Author

Alex,

I thought we never going to have all negative values.
If we do have, then yes I should change on what you said.

@agoodm
Copy link
Member

agoodm commented Jun 6, 2014

Hi Mazi,

I don't think there is a reason to assume that the values will never be negative. I recommend implementing the change I suggested anyway since it is very simple and gives the same result when the minimum is negative and the maximum is positive.

@MJJoyce
Copy link
Member

MJJoyce commented Jun 8, 2014

👍 to that Alex. Cheers for checking this.

@OCWJenkins
Copy link

Merged build triggered. Test Failed.

@OCWJenkins
Copy link

Merged build started. Test Failed.

@OCWJenkins
Copy link

Merged build finished. Test Passed.

asfgit pushed a commit that referenced this pull request Jun 11, 2014
@MBoustani MBoustani closed this Jun 11, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants