Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

CLIMATE-241 - Update plotter.py docstring formatting #83

Merged
merged 5 commits into from Jul 2, 2014

Conversation

OCWJenkins
Copy link

No description provided.

@OCWJenkins
Copy link
Author

Merged build triggered. Test Failed.

1 similar comment
@OCWJenkins
Copy link
Author

Merged build triggered. Test Failed.

@OCWJenkins
Copy link
Author

Merged build started. Test Failed.

1 similar comment
@OCWJenkins
Copy link
Author

Merged build started. Test Failed.

@OCWJenkins
Copy link
Author

Merged build finished. Test Passed.

1 similar comment
@OCWJenkins
Copy link
Author

Merged build finished. Test Passed.

@MJJoyce
Copy link
Member

MJJoyce commented Jul 1, 2014

If @agoodm could take a look and make sure all of this reads alright I would be super appreciative :)

Also, @agoodm, I noticed that the subregion function specifies that it needs "subregion objects." Do we document what exactly that means somewhere or was there a different assumption being made when this was done?

@agoodm
Copy link
Member

agoodm commented Jul 1, 2014

@MJJoyce

👍 To the actual changes. I actually liked that you clarified a few of the parameters by adding links to relative matplotlib and basemap documentation too.

Regarding the draw_subregions function, the "subRegion" object refers to the class inside the rcmet/src/main/python/rcmes/classes.py module, which I believe is what we used for subregion parsing in the past. The equivalent to this in the refactoring branch is probably ocw.dataset.Bounds.

@MJJoyce
Copy link
Member

MJJoyce commented Jul 2, 2014

Cheers @agoodm!

@asfgit asfgit merged commit e5ca869 into apache:master Jul 2, 2014
asfgit pushed a commit that referenced this pull request Jul 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants