Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PVLAN documentation #86

Merged
merged 4 commits into from May 22, 2020
Merged

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Dec 22, 2019

@nvazquez nvazquez added the feature New feature or request label Dec 22, 2019
@nvazquez
Copy link
Contributor Author

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/pr86

Build Log Output:

No log errors found to report.

@andrijapanicsb
Copy link
Contributor

LGTM in general.

But would be nice to explain things with pictures from gui as examples, or alternatively with API - I'm talking about the last few lines explaining how you can create different kind of PVLAN setups (primisc. vs isolated vs community)

@apache apache deleted a comment from ACSGitBot May 21, 2020
@apache apache deleted a comment from ACSGitBot May 21, 2020
@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr86

Build Log Output:

No log errors found to report.

@andrijapanicsb andrijapanicsb merged commit 002893c into apache:master May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
3 participants