Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resetconfiguration #47

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Resetconfiguration #47

merged 2 commits into from
Mar 29, 2023

Conversation

poddm
Copy link
Contributor

@poddm poddm commented Mar 8, 2023

mlsorensen
mlsorensen approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@mlsorensen mlsorensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested these changes locally - the changes are largely auto-generated with the addition of tests.

@mlsorensen
Copy link
Contributor

Note depending on how #38 proceeds this may be unnecessary, however I'm all for adding one API someone may need and letting the bigger change refactor out the addition of this one API, especially since #38 has been hanging for awhile.

@mlsorensen
Copy link
Contributor

mlsorensen commented Mar 29, 2023 •
edited

Merging for expedience, there has been time for others to review. Thanks for the contribution @poddm

@mlsorensen mlsorensen merged commit 275fbdc into apache:main Mar 29, 2023
@poddm poddm mentioned this pull request Apr 19, 2023
Open
@poddm poddm deleted the resetconfiguration branch October 31, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlsorensen mlsorensen mlsorensen approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poddm @mlsorensen