Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RoleService bug where response doesn't match struct #57

Closed
wants to merge 2 commits into from

Conversation

hasan07
Copy link

@hasan07 hasan07 commented Apr 14, 2023

Example raw response:

{"role":{"type":"DomainAdmin","id":"fake-id-12312312","name":"test-name","description":"test Role"}}

Struct doesn't match raw response, so the unmarshaller wasn't able to unmarshal properly and the response is always empty.

This fix handles the bug.

@mlsorensen FYI

@mlsorensen
Copy link
Contributor

We will need to fix it in the code gen. I think this is another manifestation of #55 - anything that doesn't return a list type response seems to be broken. We will need to come up with a general solution @shwstppr @rohityadavcloud

@rohityadavcloud
Copy link
Member

Agree, the changes should ideally be fixed in generator otherwise they maybe reverted the next time we update the code base against new listApis.

@mlsorensen
Copy link
Contributor

Should be resolved with #58

@mlsorensen mlsorensen closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants