-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Kubernetes 1.24.12 + Use Go 1.19 #44
Conversation
bump Kubernetes Version to 1.20.6
Please let me know if 1.26 i a bit too ambitious, i will gladly adapt for 1.24 or 1.25. |
If you have the time I would really appreciate if there is a version in between. For instance 1.24. |
yeah i was afraid of that already, i suddenly realized that compiling this against 1.26 probably means losing compatibility with 1.24 and 1.25 which are still supported. I will get on it! |
Updated PR to use Kubernetes v1.24.11 instead |
Ship it? Or does anything else need to happen? |
Signed-off-by: Hans Rakers <h.rakers@global.leaseweb.com>
Signed-off-by: Hans Rakers <h.rakers@global.leaseweb.com>
Signed-off-by: Hans Rakers <h.rakers@global.leaseweb.com>
Added a switch to klog v2 + updated PR for k8s 1.24.12 |
Signed-off-by: Hans Rakers <h.rakers@global.leaseweb.com>
@rohityadavcloud can you help getting this one merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I didn’t test it
@davidjumani could you have a quick look and help merge it. @RolphH @hrak could you advise what testing you’ve done against any/various versions of CloudStack? |
We are running this without any issues so far on Cloudstack 4.17. We have some more changes in the pipeline once this is merged. |
Well, maybe i should clarify: The part that works is the loadbalancer/firewall rules part. Most of the logic surrounding instance metadata is broken ever since this was turned into and external cloud provider.
Then there are issues with ProviderID, since the provider is currently called Passing I am working on fixes for all these issues but i would really like to get this in first. |
This PR is a continuation of the work in #32 and contains the following changes:
1.26.21.24.12I can provide a test container image if needed.